Fix root folder reference #84
Conversation
| run: | | ||
|
|
||
| # set to no deploy git mock, to simulate no interested file change scenario | ||
| mv e2e-setup/mocks/no-deploy-git.sh /usr/local/bin/git |
There was a problem hiding this comment.
fixing a case that I found after merging my previous PR, as for the no-deploy case we want to simulate a change in a file outside the root folder. This is
action.yaml
Outdated
| for file in $files; do | ||
| if [[ $file =~ ^"${{ inputs.root-folder }}".* ]]; then | ||
| if [[ $file =~ ^"$root_folder".* ]]; then |
There was a problem hiding this comment.
Do we also need some kind of validation that the root folder does not start with a forward slash, which presumably would not match with any file?
There was a problem hiding this comment.
agree on having the validation, also there are a couple of other places that could benefit from having upfront validation rather than having to fail later. But I would prefer to decouple that from this patch release so that we are focused on fixing bugs introduced in 0.7. (Will drop an issue so that we don't loose track of it)
There was a problem hiding this comment.
issue to track the change: #85
There was a problem hiding this comment.
Currently we run astronomer/[email protected] prior to astro deployment variable update in CI. If there are no changes, this step fails. Will set the root-folder to see if that gets us moving forward. Ideally these changes could be versioned, if possible, though.
There was a problem hiding this comment.
yup, since this is a fix, we are planning to release a v0.7.1 with these PR changes
Changes:
image-and-dagsdeploy type would skip deploy when a dag file is updatedgitstill, as I forgot to add mock to it, because of which the outcome of the test varied based on the changes in the commitBecause we can't test this edge case as part of the e2e test suite, I had to test it in a separate repo: https://github.com/neel-astro/example-repo-update/actions/workflows/push-to-main.yaml?query=branch%3Amain