-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customizing how dbt nodes are converted to Airflow #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
tatiana
force-pushed
the
issue-427-task-generator
branch
from
September 5, 2023 10:42
6a4b248
to
9d839b3
Compare
tatiana
force-pushed
the
issue-427-task-generator
branch
from
September 11, 2023 09:41
e3a88f5
to
78598e4
Compare
tatiana
force-pushed
the
issue-427-task-generator
branch
from
October 9, 2023 14:14
9db8c8e
to
ea61ef7
Compare
tatiana
changed the title
WIP: Support customization of how Dbt resources are converted to Airflow
Support customizing how dbt nodes are converted to Airflow
Oct 9, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 93.01% 93.04% +0.02%
==========================================
Files 51 51
Lines 2019 2041 +22
==========================================
+ Hits 1878 1899 +21
- Misses 141 142 +1
☔ View full report in Codecov by Sentry. |
tatiana
force-pushed
the
issue-427-task-generator
branch
from
October 9, 2023 15:21
52632b3
to
01e2a33
Compare
…ignore unnecessary files on dbt projects
tatiana
force-pushed
the
issue-427-task-generator
branch
from
October 10, 2023 09:54
683abea
to
d39c689
Compare
tatiana
commented
Oct 12, 2023
tatiana
commented
Oct 12, 2023
tatiana
commented
Oct 12, 2023
tatiana
commented
Oct 12, 2023
tatiana
commented
Oct 12, 2023
tatiana
commented
Oct 12, 2023
harels
approved these changes
Oct 12, 2023
cosmos/airflow/graph.py:224: error: Call to untyped function (unknown) in typed context [no-untyped-call] https://github.com/astronomer/astronomer-cosmos/actions/runs/6506710243/job/17672777673\?pr\=503
Merged
tatiana
added a commit
that referenced
this pull request
Oct 13, 2023
**Features** * Add support to model versioning available since dbt 1.6 by @binhnq94 in #516 * Add AWS Athena profile mapping by @benjamin-awd in #578 * Support customizing how dbt nodes are converted to Airflow by @tatiana in #503 * Make the arg ``dbt_project_path`` in the ``ProjectConfig`` optional by @MrBones757 in #581 **Bug fixes** * Fix Cosmos custom selector to support filtering a single model by @jlaneve and @harels in #576 * Fix using ``GoogleCloudServiceAccountDictProfileMapping`` together with ``LoadMethod.DBT_LS`` by @joppevos in #587 * Fix using the ``full_refresh`` argument in projects that contain tests by @EgorSemenov and @tatiana in #590 * Stop creating symbolic links for ``dbt_packages`` (solves ``LocalExecutor`` concurrency issue) by @tatiana in #600 **Others** * Docs: add reference to original Jaffle Shop project by @erdos2n in #583 * Docs: retries & note about DagBag error by @TJaniF in #592 * pre-commit updates in #575 and #585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to solve the following current limitations of Cosmos 1.0:
It does this by introducing the parameter
node_converters
toRenderConfig
, which allows users to define a custom function to convert a DbtNode into nothing or an Airflow resource (Operator or TaskGroup instances).Example of the feature
Is now rendered in Airflow:
Before this change, there was no way for users to describe how to render source or other unsupported dbt resources.
Related Issue(s)
Closes: #427
Closes: #477
Breaking Change?
No
Checklist
Feedback addressed:
DbtResourceType