Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update: retries note about Dagbag error. #592

Merged
merged 11 commits into from
Oct 13, 2023

Conversation

TJaniF
Copy link
Contributor

@TJaniF TJaniF commented Oct 11, 2023

Description

Based on this Slack thread: https://astronomer.slack.com/archives/C015V2JFKT5/p1696873122011889. Hope I understood the recommendation correctly :)

  • Added retries of 2 to code samples
  • Added a note about the config variable to fix dagbag timeout errors

@TJaniF TJaniF requested a review from a team as a code owner October 11, 2023 08:45
@TJaniF TJaniF requested a review from a team October 11, 2023 08:45
@netlify
Copy link

netlify bot commented Oct 11, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 36e655d
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/6529384207f6280008d1c2c4

@pre-commit-ci pre-commit-ci bot temporarily deployed to external October 11, 2023 08:46 Inactive
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contributions, @TJaniF !
Some comments inline

docs/getting_started/astro.rst Outdated Show resolved Hide resolved
@TJaniF TJaniF temporarily deployed to external October 11, 2023 09:54 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e80abd7) 93.09% compared to head (b5cf9e0) 93.01%.
Report is 1 commits behind head on main.

❗ Current head b5cf9e0 differs from pull request most recent head 36e655d. Consider uploading reports for the commit 36e655d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   93.09%   93.01%   -0.08%     
==========================================
  Files          51       51              
  Lines        2041     2019      -22     
==========================================
- Hits         1900     1878      -22     
  Misses        141      141              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pre-commit-ci pre-commit-ci bot temporarily deployed to external October 11, 2023 11:10 Inactive
@TJaniF TJaniF changed the title Docs update: retries, schedule and note about Dagbag error. Docs update: retries note about Dagbag error. Oct 11, 2023
@tatiana tatiana added this to the 1.2.0 milestone Oct 13, 2023
@tatiana tatiana temporarily deployed to external October 13, 2023 10:57 — with GitHub Actions Inactive
@tatiana tatiana merged commit a85f2f1 into astronomer:main Oct 13, 2023
19 of 20 checks passed
@tatiana tatiana mentioned this pull request Oct 13, 2023
tatiana added a commit that referenced this pull request Oct 13, 2023
**Features**

* Add support to model versioning available since dbt 1.6 by @binhnq94
in #516
* Add AWS Athena profile mapping by @benjamin-awd in #578
* Support customizing how dbt nodes are converted to Airflow by @tatiana
in #503
* Make the arg ``dbt_project_path`` in the ``ProjectConfig`` optional by
@MrBones757 in #581

**Bug fixes**

* Fix Cosmos custom selector to support filtering a single model by
@jlaneve and @harels in #576
* Fix using ``GoogleCloudServiceAccountDictProfileMapping`` together
with ``LoadMethod.DBT_LS`` by @joppevos in #587
* Fix using the ``full_refresh`` argument in projects that contain tests
by @EgorSemenov and @tatiana in #590
* Stop creating symbolic links for ``dbt_packages`` (solves
``LocalExecutor`` concurrency issue) by @tatiana in #600

**Others**

* Docs: add reference to original Jaffle Shop project by @erdos2n in
#583
* Docs: retries & note about DagBag error by @TJaniF in #592
* pre-commit updates in #575 and #585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants