improve messaging with typedDicts #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an error when adjust marginal_costs for multiple markets use market_id consistently receive registration feedback from market at start of simulation
maurerle
force-pushed
the
improve_messaging
branch
from
1beb453 to
0cbb701
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 78.13% 78.28% +0.15%
==========================================
Files 40 40
Lines 4198 4242 +44
==========================================
+ Hits 3280 3321 +41
- Misses 918 921 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nick-harder
approved these changes
Nov 8, 2023
nick-harder
pushed a commit
that referenced
this pull request
Nov 13, 2023
* add tests for base_unit * remove global start and end in flex storage test We still had an issue in the marginal_cost calculation which I fixed in a wrong way in #245 This is now tested and fixed. While testing, I found that the product_type was not used in the get_output_before function too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an error when
adjust marginal_costs for multiple markets
use market_id consistently
receive registration feedback from market at start of simulation