Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes calculation of marginal cost and output_before #250

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

maurerle
Copy link
Member

  • add tests for base_unit
  • remove global start and end in flex storage test

We still had an issue in the marginal_cost calculation which I fixed in a wrong way in #245
This is now tested and fixed.
While testing, I found that the product_type was not used in the get_output_before function too.

* add tests for base_unit
* remove global start and end in flex storage test
@maurerle maurerle requested a review from kim-mskw November 12, 2023 12:19
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c32a623) 78.21% compared to head (cc74f6d) 78.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   78.21%   78.33%   +0.11%     
==========================================
  Files          39       39              
  Lines        4214     4218       +4     
==========================================
+ Hits         3296     3304       +8     
+ Misses        918      914       -4     
Flag Coverage Δ
pytest 78.33% <90.47%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
assume/common/units_operator.py 90.95% <100.00%> (+0.40%) ⬆️
assume/markets/base_market.py 87.56% <100.00%> (+0.06%) ⬆️
assume/common/base.py 80.26% <85.71%> (+1.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if the powerplant is not turned on, no generation cost exists
this creates a weird way to create profit - by not prividing energy though
@maurerle maurerle requested a review from nick-harder November 13, 2023 13:13
@nick-harder nick-harder merged commit 61d58a8 into main Nov 13, 2023
4 checks passed
@nick-harder nick-harder deleted the fix_marginal_cost branch November 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants