Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-adding eval episodes #209

Merged
merged 2 commits into from
Sep 27, 2023
Merged

-adding eval episodes #209

merged 2 commits into from
Sep 27, 2023

Conversation

nick-harder
Copy link
Member

-restructing load scenario
-adjusting outputs

-restructing load scenario
-adjusting outputs
@nick-harder nick-harder marked this pull request as ready for review September 26, 2023 15:39
@nick-harder
Copy link
Member Author

Somehow always when running in RL mode (the RL base example) I get some error but only in the very first episode. I am not sure why and couldn't figure it out. Could you please check it @maurerle?

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ac75b59) 80.89% compared to head (b4ecc4a) 80.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   80.89%   80.94%   +0.04%     
==========================================
  Files          40       40              
  Lines        4057     4067      +10     
==========================================
+ Hits         3282     3292      +10     
  Misses        775      775              
Flag Coverage Δ
pytest 80.94% <96.29%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
assume/common/outputs.py 81.02% <100.00%> (+0.39%) ⬆️
assume/common/units_operator.py 91.35% <100.00%> (ø)
assume/world.py 83.68% <100.00%> (+0.26%) ⬆️
assume/common/scenario_loader.py 89.17% <92.85%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maurerle maurerle merged commit db2fa3f into main Sep 27, 2023
4 checks passed
@maurerle maurerle deleted the add-eval-episodes branch September 27, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants