Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #1852

Merged
merged 29 commits into from
Nov 8, 2024
Merged

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Oct 28, 2024

Description

This PR removes deprecated API. See docs link below for more details.

Closes #1698
Closes #1859

It needs:

The major changes to make sure to note are:

  • no more namedtuple support (so we can handle these with Extensions/Converters)
  • use of a tag uri for a schema $ref will no longer resolve
  • resolve_references is no longer called for AsdfFile.__init__ or asdf.open

Checklist:

  • pre-commit checks ran successfully

  • tests ran successfully

  • for a public change, added a towncrier news fragment

    changes/<PR#>.<changetype>.rst

    • changes/<PR#>.feature.rst: new feature
    • changes/<PR#>.bugfix.rst: bug fix
    • changes/<PR#>.doc.rst: documentation change
    • changes/<PR#>.removal.rst: deprecation or removal of public API
    • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • for a public change, updated documentation

  • for any new features, unit tests were added

asdf/schema.py Outdated Show resolved Hide resolved
asdf/schema.py Outdated Show resolved Hide resolved
@braingram braingram added this to the 4.0.0 milestone Oct 28, 2024
@braingram braingram force-pushed the rm_4p0_deprecations branch from a2e1c7e to 06b45e9 Compare October 29, 2024 16:39
@braingram braingram changed the title Rm 4p0 deprecations Remove deprecated code Oct 30, 2024
@braingram braingram marked this pull request as ready for review October 30, 2024 13:29
@braingram braingram requested a review from a team as a code owner October 30, 2024 13:29
@braingram braingram force-pushed the rm_4p0_deprecations branch from 89b59c9 to 048fb06 Compare October 31, 2024 16:47
@braingram braingram force-pushed the rm_4p0_deprecations branch from 048fb06 to 3e63541 Compare November 7, 2024 18:20
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the weldex failure is not an issue.

@braingram
Copy link
Contributor Author

LGTM, assuming the weldex failure is not an issue.

Thanks! There is a PR that fixes the error:
BAMWelDX/weldx#910

I may open a smaller one that's just that error since the above PR also has schema changes (although those are required for #1744).

@braingram braingram merged commit abeef0e into asdf-format:main Nov 8, 2024
48 of 49 checks passed
@braingram braingram deleted the rm_4p0_deprecations branch November 8, 2024 13:34
@braingram braingram mentioned this pull request Nov 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copy_arrays removal to "what's new" Remove deprecated features
2 participants