Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove copy_arrays parameter #1800

Merged
merged 1 commit into from
Nov 7, 2024
Merged

remove copy_arrays parameter #1800

merged 1 commit into from
Nov 7, 2024

Conversation

zacharyburnett
Copy link
Member

@zacharyburnett zacharyburnett commented Jul 15, 2024 •
edited
Loading

Description

deprecate copy_arrays

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@zacharyburnett zacharyburnett self-assigned this Jul 15, 2024
@zacharyburnett zacharyburnett added this to the 4.0.0 milestone Jul 15, 2024
@zacharyburnett zacharyburnett linked an issue Jul 15, 2024 that may be closed by this pull request
Remove copy_arrays and switch memmap default to False #1711
Closed
@zacharyburnett zacharyburnett force-pushed the remove/copy_arrays branch 2 times, most recently from 0c13e96 to 3f7a2a3 Compare October 31, 2024 16:15
@zacharyburnett zacharyburnett changed the title remove copy_arrays parameter remove copy_arrays parameter and default memmap to False Oct 31, 2024
@zacharyburnett zacharyburnett changed the title remove copy_arrays parameter and default memmap to False remove copy_arrays parameter Oct 31, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review October 31, 2024 16:29
@zacharyburnett zacharyburnett requested a review from a team as a code owner October 31, 2024 16:29
@zacharyburnett zacharyburnett mentioned this pull request Oct 31, 2024
Merged
5 tasks
@braingram braingram mentioned this pull request Oct 31, 2024
Closed
braingram
braingram approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@braingram braingram left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

We'll also want an entry in "what's new". I vote for putting that in a separate PR after #1852 since that PR adds the page and many items. I opened an issue to track that:
#1859

The downstream abacusutils failure is expected (since it still uses copy_arrays).
EDIT: Thanks! abacusorg/abacusutils#157

@braingram braingram merged commit d717270 into asdf-format:main Nov 7, 2024
78 checks passed
@zacharyburnett zacharyburnett deleted the remove/copy_arrays branch November 7, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
Downstream CI
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Remove copy_arrays and switch memmap default to False
2 participants
@zacharyburnett @braingram