Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support android app #191

Closed
wants to merge 0 commits into from
Closed

fix: support android app #191

wants to merge 0 commits into from

Conversation

oldkingOK
Copy link

@oldkingOK oldkingOK commented Sep 16, 2023 •
edited
Loading

See #52

@oldkingOK oldkingOK changed the title fix: support android app (keyboard letter mode needed) fix: support android app Sep 17, 2023
@artisticat1
Copy link
Owner

Thanks for the PR! Is this ready for review, or does it still need further testing and debugging?

@oldkingOK
Copy link
Author

oldkingOK commented Sep 19, 2023 •
edited
Loading

It is not ready. Some features still need testing and debugging.

@oldkingOK oldkingOK closed this Sep 20, 2023
@oldkingOK
Copy link
Author

I'm sorry for the misoperation, I'm not so familiar with it because it's my first time opening a PR.
Btw it is ready for review.

@oldkingOK oldkingOK reopened this Sep 20, 2023
artisticat1
artisticat1 reviewed Sep 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
artisticat1
artisticat1 reviewed Sep 23, 2023
View reviewed changes
src/latex_suite.ts Outdated
@@ -109,7 +116,8 @@ export const handleTabstops = (view: EditorView) =>
// CodeMirror extensions that are required for Latex Suite to run
export const latexSuiteExtensions = (settings: LatexSuiteProcessedSettings) => [
getLatexSuiteConfigExtension(settings),
Prec.highest(EditorView.domEventHandlers({"keydown": onKeydown})), // Register keymaps
Prec.highest(EditorView.domEventHandlers({"keydown":
Platform.isAndroidApp ? onAndroidKeydown : onKeydown})), // Register keymaps. Compatibility for android users with IME keyboard
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove the Platform.isAndroidApp check and make the fix platform-independent? The goal is to make Latex Suite a pure CodeMirror extension, with no dependency on Obsidian. This will allow it to be embedded in any other CM editor, e.g. on the web.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I need to edit some code in latex_suite.ts to make this fix platform-independent, which requires more testing and debugging.

@oldkingOK
Copy link
Author

Hi @IEatCodeDaily ,@awsharif,
Can you guys help me test the latest build , I edited some key parts of the code and need a lot of testing work, thanks!

@IEatCodeDaily
Copy link

IEatCodeDaily commented Oct 10, 2023 •
edited
Loading

Sorry, didn't check email for quite a while. Didn't know I got tagged here.

Just tested it on Samsung A50 and Samsung Galaxy Tab S6 (w/ and w/out physical keyboard).
Work flawlessly with Samsung Keyboard, Gboard, MS SwiftKey, and Simple Keyboard all with auto-correction enabled.
Auto-correction still works on Samsung Keyboard and Gboard, but doesn't work on MS SwiftKey and Simple Keyboard.
Not a big deal when typing using physical keyboard, but a minor inconvenience when using on-screen keyboard.

The same double snippets entry bug I mentioned in #52 still happen when make.md is also installed though. But I have no idea whether the fault is on make.md or latex-suite.

Amazing job! I'll be using your fork on my phone/tablet until the PR is (hopefully) approved. Thank you so much!

@artisticat1 artisticat1 mentioned this pull request Oct 21, 2023
Open
@oldkingOK oldkingOK closed this Oct 24, 2023
@oldkingOK oldkingOK reopened this Oct 24, 2023
@DuncanBH
Copy link

DuncanBH commented Jan 17, 2024 •
edited
Loading

Heya I just set up the plugin (V1.9.0) on my Tab S9 (Android 14, One UI 6.0), I've run into similar issues as to what's been described here and in #213
Haven't had any luck with the on screen keyboard, I did get it working with a physical keyboard by turning off the predictive text. It was a Bluetooth keyboard, I'll test out it on the official flipbook keyboard case when I get my hands on one soon.

Is there another solution I've missed somewhere? I'd like the predictive text but I suppose I could just switch it off when using the plugin.

Let me know if there's anything I can do to help, I don't have the time rn to try and figure this out & get a PR going sorry.

@oldkingOK oldkingOK closed this Jan 21, 2024
@artisticat1 artisticat1 mentioned this pull request Apr 23, 2024
Closed
@CamWam
Copy link

CamWam commented Sep 30, 2024

@oldkingOK
Hello,The link https://github.com/oldkingOK/obsidian-latex-suite/releases/tag/v0.0.4 is not working. Could you please re-upload it? Thank you very much.

@oldkingOK
Copy link
Author

@oldkingOK Hello,The link https://github.com/oldkingOK/obsidian-latex-suite/releases/tag/v0.0.4 is not working. Could you please re-upload it? Thank you very much.

@CamWam
Sorry for the delay. This link leads to one of my previous and outdated repositories. I recently updated the code, can you test this below?
https://github.com/oldkingOK/obsidian-latex-suite/releases/tag/1.9.7-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artisticat1 artisticat1 artisticat1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oldkingOK @artisticat1 @IEatCodeDaily @DuncanBH @CamWam