-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Plugin not working on Samsung tablets after upgrading to OneUI 5.1.1 #213
Comments
I have the same problem, Samsung Galaxy S7 FE with One UI 5.1.1. I noticed that some of the snippets still work in math mode. For example, the "/" after a character activates the "\frac{}{}" snippet. |
Can you try out the build in #191 and check whether the plugin works again? |
Now on my Galaxy S7 FE the plugin works only with the physical keyboard and text prediction disabled. I tried Samsung, Gboard and AnySoft. |
I'm not very familiar with GitHub, if you could tell me how I'd be more than happy to |
Just update the plugin in obsidian and check if it works for you. |
Of course. Download the Then replace
The fix in #191 actually hasn't been released as an update yet, so if you could follow the steps above and report back that'd be great! |
Sorry man, still not working. Some snippets work just fine (a/b for frac, << for /ll) but not mk, dm or any other. I've tried both on the physical keyboard and the system's one |
Hi @lukks22 .
|
Hi @lukks22 . I don't have any Samsung machines around, so it would be helpful if you could describe the situation in more detail.
* What keyboard app are you using?
* Is the composition mode off? (when on, words are underlined during spelling). You can view [how to turn off it for some keyboards here](https://github.com/oldkingOK/obsidian-latex-suite/discussions/4).
Hi, I'm using the default keyboard.
I have tried turning it off and it works both on the physical and the
native one.
|
Oh sorry, I saw an update and I thought that was the fix. I just tested with the new main.js file and the result is pretty much the same, except that now I can leave text prediction on. Only the physical keyboard works. |
My bad, the on-screen samsung keyboard works too, I was testing the snippets with the automatic initial upper case😅 The on-screen keyboard doesn't work with text prediction on but the physical one does. |
I'm having trouble dealing with the text prediction function.
I haven't found a solution for the first problem yet, for the second problem the solution I use is to listen for input event, which is called for every keyboard apps, for every key pressed from A to Z or symbols. For most keyboard apps, when All keyboard apps tested so far work fine with text prediction mode turned off. However, the problem is complicated by the fact that each app processes text differently when the mode is activated.
I tried to use input event's Any help is welcome! |
Hi @oldkingOK. Thank you for the detailed analysis! I'm not as familiar with IME input as you, but as far as I'm aware, the vim CM6 plugin does not run into any of these issues with IME input. (At least, there have been no user reports of problems as far as I can tell.) It appears to work with |
hello ! i have a similar issue on a nothing phone (1). I wish this info help someone :) |
Hi @artisticat1. Sorry for the late reply.
This plugin does deal with the IME issue, and I used your suggestion in a previous version, but this solution causes the user to not be able to use the word prediction feature of the keyboard. Maybe a good solution would be to give the user a floating button or hotkey shortcut to quickly switch between "Latex Suite Mode" and "Text Input Mode"? In that case there's no way to remove the
vim CM6 plugin also detects the if (
this.lastKeydown == "Unidentified"
|| this.lastKeydown == "Process"
|| this.lastKeydown == "Dead"
) {
this.useNextTextInput = true;
} else {
this.useNextTextInput = false;
this.handleKey(e, view);
} When EditorView.inputHandler.of((view, from, to, text) => {
...
if (text.length == 1 && vimPlugin.useNextTextInput) {
vimPlugin.handleKey({
key: text,
preventDefault: ()=>{},
stopPropagation: ()=>{}
});
forceEndComposition(view); // Here
return true;
}
...
} The forceEndComposition(view) function refreshes the page, forcing the IME to be disabled and causing word prediction to be disabled. Obsidian's app.js code handles IMEs similarly, with the function in the following code corresponding to function (e) {
var t = e.scrollDOM.parentElement;
if (!t) return;
if (UT) return e.contentDOM.textContent = "\0\0", void e.contentDOM.dispatchEvent(new CustomEvent("compositionend"));
var n = e.scrollDOM.nextSibling,
i = window.getSelection(),
r = i && {
anchorNode: i.anchorNode,
anchorOffset: i.anchorOffset,
focusNode: i.focusNode,
focusOffset: i.focusOffset
};
e.scrollDOM.remove(), t.insertBefore(e.scrollDOM, n);
try {
r && i && (i.setPosition(r.anchorNode, r.anchorOffset), r.focusNode && i.extend(r.focusNode, r.focusOffset))
} catch (e) {
console.error(e)
}
e.focus(), e.contentDOM.dispatchEvent(new CustomEvent("compositionend"))
}(e) |
No worries, I appreciate your help!
I see. That might work, but toggling between modes would make for a frustrating UX, so I'd prefer to fix the root cause of the issue. (Ideally, we find a solution where word prediction/suggestions work properly out of the box.) Using an
However, word suggestions seem to work fine with vim mode enabled on Android. Thus, it's not obvious to me why there would be issues with word suggestions and Latex Suite? |
Just a random thought from a non-experienced dev who doesn't have an Android device, but it might be worth trying to use Here's an example from my plugin: See here for |
I'm using a Samsung tab S8+ OneUI6.0 and I'm having the same problem with the plugin not working properly. I've tried turning off the spell checking related settings in both system, gboard and obsidian but all attempts have failed... |
Description
Since the upgrade, me and (at least) another user can't use the shortcuts anymore, not even mk, dm or any custom ones.
Expected Behavior
Shortcuts should have effect
Additional Info
None
Platform
Samsung tablets (found on Samsung Galaxy S7 FE and Galaxy Tab S6 Lite) with One UI 5.1.1
Before the update the shortcuts would not work when using the "virtual" keyboard, but would work with a bluetooth one. After the update not even that. The same project on Windows works fine.
The text was updated successfully, but these errors were encountered: