[Redshift] Increase String Precision - Part 2 #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
changed the title
danafallon
reviewed
Oct 16, 2024
danafallon
reviewed
Oct 16, 2024
| @@ -126,6 +127,10 @@ func (c *Columns) UpsertColumn(colName string, arg UpsertColumnArg) { | |||
| col.backfilled = *arg.Backfilled | |||
| } | |||
|
|
|||
| if arg.StringPrecision != nil { | |||
| col.KindDetails.OptionalStringPrecision = arg.StringPrecision | |||
There was a problem hiding this comment.
Since this has access to the existing column metadata, is this a better place to check that the new precision is greater than the previous?
There was a problem hiding this comment.
We already have guardrail in how NewLength is being set, I can add something here as well?
There was a problem hiding this comment.
My main concern was addressed on the other comment, but yeah it might be nice to add a backup check here too, just in case.
There was a problem hiding this comment.
Yeah I don't see why not. I'll add it
There was a problem hiding this comment.
I'm gonna open up another PR to add error to the signature for UpsertColumn so there's less diff
danafallon
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one - #953
Background
This is the second PR to enable automatic string precision for Redshift.
Scope