Update UpsertColumn to include an error response #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danafallon
reviewed
Oct 16, 2024
| Backfilled: typing.ToPtr(true), | ||
| }) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
Although with the multiple lines that could make it hard to read, so I'm also good with leaving it as is.
danafallon
reviewed
Oct 16, 2024
lib/typing/columns/columns_test.go
Outdated
| ToastCol: typing.ToPtr(true), | ||
| PrimaryKey: typing.ToPtr(true), | ||
| }) | ||
| })) | ||
| aaaCol, _ := cols.GetColumn("aaa") | ||
| assert.True(t, aaaCol.ToastColumn) | ||
| assert.True(t, aaaCol.primaryKey) | ||
| assert.Equal(t, aaaCol.KindDetails, typing.Invalid) | ||
|
|
||
| length := len(cols.columns) | ||
| for i := 0; i < 500; i++ { |
There was a problem hiding this comment.
How come we're doing this 500 times?
There was a problem hiding this comment.
Lol, I was testing it to be idempotent. It's not needed though, I'll remove.
danafallon
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this in so we can have an extra guardrail to address #955 (comment)