[mssql] Escape all columns that do not start with "__artie" #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
reviewed
Apr 24, 2024
| @@ -25,7 +25,7 @@ func NeedsEscaping(name string, destKind constants.DestinationKind) bool { | |||
| if destKind == constants.Redshift { | |||
| reservedKeywords = constants.RedshiftReservedKeywords | |||
| } else if destKind == constants.MSSQL { | |||
| reservedKeywords = constants.MSSQLReservedKeywords | |||
| return !strings.HasPrefix(name, constants.ArtiePrefix) | |||
There was a problem hiding this comment.
I wanted to but if we escape all columns we get test errors that say artie delete flag doesn't exist.
There was a problem hiding this comment.
I'm guessing there must be some places where we escape the column names and then check if the column names contain a specific value.
There was a problem hiding this comment.
That's a guardrail in dml/merge
There was a problem hiding this comment.
The comparison is running "__artie_deleted" == __artie_deleted which will always equate to false
Tang8330
approved these changes
Apr 24, 2024
This was referenced Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.