[bigquery] Escape all columns that do not start with "__artie" #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Apr 29, 2024
| } else if destKind == constants.MSSQL { | ||
| return !strings.HasPrefix(name, constants.ArtiePrefix) | ||
| } else if destKind == constants.MSSQL || destKind == constants.BigQuery { | ||
| if !strings.HasPrefix(name, constants.ArtiePrefix) { |
There was a problem hiding this comment.
I changed this so that in the case that the name does start with constants.ArtiePrefix we don't immediately return so that we still run the logic for checking symbolsToEscape.
There was a problem hiding this comment.
Why do that? There should never be reserved keywords that have the Artie prefix
There was a problem hiding this comment.
So that __artie_foo:bar still gets escaped.
Tang8330
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since BigQuery does not change the case of identifiers when they are not quoted we should be able to always quote column identifiers. This is based on #501 but BigQuery instead of MS SQL.