Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate welcome module dependencies #299

Merged
merged 7 commits into from
Oct 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,11 @@ dependencies {
implementation project(':base')
implementation project(':splash')
implementation project(':welcome')
implementation project(':tours')
implementation project(':content_listing')
implementation project(':tour_manager')
implementation project(':info')
implementation project(':audio')
implementation project(':map')
implementation project(':exhibitions')
implementation project(':events')
implementation project(':analytics')
implementation project(':media')
implementation project(':media_ui')
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions content_listing/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="edu.artic.content.listing" />
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.fuzz.rx.disposedBy
import com.jakewharton.rxbinding2.widget.text
import edu.artic.adapter.AutoHolderRecyclerViewAdapter
import edu.artic.adapter.BaseViewHolder
import edu.artic.content.listing.R
import edu.artic.image.GlideApp
import kotlinx.android.synthetic.main.cell_all_events_layout.view.*

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ import edu.artic.adapter.itemChanges
import edu.artic.adapter.itemClicksWithPosition
import edu.artic.analytics.ScreenName
import edu.artic.base.utils.asDeepLinkIntent
import edu.artic.content.listing.R
import edu.artic.events.recyclerview.AllEventsItemDecoration
import edu.artic.navigation.NavigationConstants
import edu.artic.viewmodel.BaseViewModelFragment
import edu.artic.viewmodel.Navigate
import io.reactivex.rxkotlin.subscribeBy
import kotlinx.android.synthetic.main.fragment_all_events.*
import kotlinx.android.synthetic.main.fragment_view_all.*
import kotlin.reflect.KClass

class AllEventsFragment : BaseViewModelFragment<AllEventsViewModel>() {
Expand All @@ -28,7 +29,7 @@ class AllEventsFragment : BaseViewModelFragment<AllEventsViewModel>() {
override val viewModelClass: KClass<AllEventsViewModel>
get() = AllEventsViewModel::class
override val layoutResId: Int
get() = R.layout.fragment_all_events
get() = R.layout.fragment_view_all

override val title = R.string.events

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import android.content.Context
import android.graphics.Rect
import android.support.v7.widget.RecyclerView
import android.view.View
import edu.artic.content.listing.R
import edu.artic.events.AllEventsAdapter
import edu.artic.events.AllEventsCellHeaderViewModel
import edu.artic.events.AllEventsCellViewModel
import edu.artic.events.R

class AllEventsItemDecoration(
context: Context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.fuzz.rx.disposedBy
import com.jakewharton.rxbinding2.widget.text
import edu.artic.adapter.AutoHolderRecyclerViewAdapter
import edu.artic.adapter.BaseViewHolder
import edu.artic.content.listing.R
import edu.artic.image.GlideApp
import kotlinx.android.synthetic.main.cell_all_exhibitions_layout.view.*

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ import edu.artic.adapter.itemChanges
import edu.artic.adapter.itemClicksWithPosition
import edu.artic.analytics.ScreenName
import edu.artic.base.utils.asDeepLinkIntent
import edu.artic.content.listing.R
import edu.artic.exhibitions.recyclerview.AllExhibitionsItemDecoration
import edu.artic.navigation.NavigationConstants
import edu.artic.viewmodel.BaseViewModelFragment
import edu.artic.viewmodel.Navigate
import io.reactivex.android.schedulers.AndroidSchedulers
import io.reactivex.rxkotlin.subscribeBy
import kotlinx.android.synthetic.main.fragment_all_exhibitions.*
import kotlinx.android.synthetic.main.fragment_view_all.*
import kotlin.reflect.KClass

class AllExhibitionsFragment : BaseViewModelFragment<AllExhibitionsViewModel>() {
Expand All @@ -29,7 +30,7 @@ class AllExhibitionsFragment : BaseViewModelFragment<AllExhibitionsViewModel>()
override val viewModelClass: KClass<AllExhibitionsViewModel>
get() = AllExhibitionsViewModel::class
override val layoutResId: Int
get() = R.layout.fragment_all_exhibitions
get() = R.layout.fragment_view_all

override val title = R.string.onView

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.content.Context
import android.graphics.Rect
import android.support.v7.widget.RecyclerView
import android.view.View
import edu.artic.exhibitions.R
import edu.artic.content.listing.R

class AllExhibitionsItemDecoration(
context: Context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import com.fuzz.rx.disposedBy
import com.jakewharton.rxbinding2.widget.text
import edu.artic.adapter.AutoHolderRecyclerViewAdapter
import edu.artic.adapter.BaseViewHolder
import edu.artic.content.listing.R
import io.reactivex.subjects.Subject
import edu.artic.image.GlideApp
import kotlinx.android.synthetic.main.cell_all_tours_intro.view.*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ import edu.artic.adapter.itemChanges
import edu.artic.adapter.itemClicksWithPosition
import edu.artic.analytics.ScreenName
import edu.artic.base.utils.asDeepLinkIntent
import edu.artic.content.listing.R
import edu.artic.navigation.NavigationConstants
import edu.artic.tours.recyclerview.AllToursItemDecoration
import edu.artic.viewmodel.BaseViewModelFragment
import edu.artic.viewmodel.Navigate
import io.reactivex.android.schedulers.AndroidSchedulers
import io.reactivex.rxkotlin.subscribeBy
import kotlinx.android.synthetic.main.fragment_all_tours.*
import kotlinx.android.synthetic.main.fragment_view_all.*
import kotlin.reflect.KClass

class AllToursFragment : BaseViewModelFragment<AllToursViewModel>() {
Expand All @@ -30,7 +31,7 @@ class AllToursFragment : BaseViewModelFragment<AllToursViewModel>() {
override val viewModelClass: KClass<AllToursViewModel>
get() = AllToursViewModel::class
override val layoutResId: Int
get() = R.layout.fragment_all_tours
get() = R.layout.fragment_view_all

override val title = R.string.tours

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.content.Context
import android.graphics.Rect
import android.support.v7.widget.RecyclerView
import android.view.View
import edu.artic.tours.R
import edu.artic.content.listing.R

class AllToursItemDecoration(
context: Context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:animateLayoutChanges="true">
android:animateLayoutChanges="true"
tools:theme="@style/AppTheme"
>

<android.support.v7.widget.Toolbar
android:id="@+id/toolbar"
Expand All @@ -16,7 +18,7 @@
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintHeight_max="?attr/actionBarSize"
tools:title="Tours"
tools:title="@tools:sample/lorem"
tools:layout_height="52dp" >

<ImageView
Expand All @@ -30,11 +32,10 @@
android:id="@+id/recyclerView"
android:layout_width="0dp"
android:layout_height="0dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/toolbar"
tools:listitem="@layout/cell_all_tours_intro"
app:layout_constraintBottom_toBottomOf="parent"
/>

</android.support.constraint.ConstraintLayout>
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:tools="http://schemas.android.com/tools">

<dimen name="all_tour_cell_spacing_vertical">23dp</dimen>
<dimen name="all_tour_cell_spacing_vertical_header" tools:ignore="MissingDefaultResource">@dimen/marginDouble</dimen>
<dimen name="all_tour_cell_spacing_horizontal">16dp</dimen>

<dimen name="all_exhibitions_cell_spacing_vertical">18dp</dimen>
<dimen name="all_exhibitions_cell_spacing_horizontal">16dp</dimen>

</resources>
2 changes: 0 additions & 2 deletions events/src/main/AndroidManifest.xml

This file was deleted.

40 changes: 0 additions & 40 deletions events/src/main/res/layout/fragment_all_events.xml

This file was deleted.

10 changes: 0 additions & 10 deletions events/src/main/res/menu/menu_all_events.xml

This file was deleted.

1 change: 0 additions & 1 deletion exhibitions/.gitignore

This file was deleted.

21 changes: 0 additions & 21 deletions exhibitions/build.gradle

This file was deleted.

21 changes: 0 additions & 21 deletions exhibitions/proguard-rules.pro

This file was deleted.

2 changes: 0 additions & 2 deletions exhibitions/src/main/AndroidManifest.xml

This file was deleted.

40 changes: 0 additions & 40 deletions exhibitions/src/main/res/layout/fragment_all_exhibitions.xml

This file was deleted.

10 changes: 0 additions & 10 deletions exhibitions/src/main/res/menu/menu_all_exhibitions.xml

This file was deleted.

5 changes: 0 additions & 5 deletions exhibitions/src/main/res/values/dimens.xml

This file was deleted.

6 changes: 2 additions & 4 deletions settings.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
include ':adapter',
':membership',
':access_card',
':analytics',
':app',
':audio',
':base',
':content_listing',
':db',
':details',
':events',
':exhibitions',
':image',
':info',
':localization',
Expand All @@ -18,10 +16,10 @@ include ':adapter',
':map',
':media',
':media_ui',
':membership',
':navigation',
':search',
':splash',
':tours',
':tour_manager',
':ui',
':viewmodel',
Expand Down
1 change: 0 additions & 1 deletion tours/.gitignore

This file was deleted.

Loading