Consolidate welcome module dependencies #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -161,6 +169,22 @@ class AccessMemberCardFragment : BaseViewModelFragment<AccessMemberCardViewModel | |||
| .disposedBy(disposeBag) | |||
| } | |||
|
|
|||
| override fun setupNavigationBindings(viewModel: AccessMemberCardViewModel) { | |||
| super.setupNavigationBindings(viewModel) | |||
| viewModel.navigateTo | |||
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
| when (it) { | ||
| is Navigate.Forward -> { | ||
| when (it.endpoint) { | ||
| viewModel.navigateTo |
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
Cliabhach
force-pushed
the
pc-consolidate-welcome-module-dependencies
branch
from
f7e9613 to
ceaeee5
Compare
Cliabhach
changed the title
Cliabhach
force-pushed
the
pc-consolidate-welcome-module-dependencies
branch
from
ceaeee5 to
1df832f
Compare
Cliabhach
force-pushed
the
pc-consolidate-welcome-module-dependencies
branch
from
1df832f to
ac1701d
Compare
caguilar187
previously approved these changes
Oct 22, 2018
This is intended for use primarily by the `All` fragments.
Cliabhach
force-pushed
the
pc-consolidate-welcome-module-dependencies
branch
from
ac1701d to
b9c1793
Compare
caguilar187
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers some of the groundwork implied by issue #298. It depends on #297, so please wait until that PR is merged before merging this.
Essentially, this PR creates a single module out of the contents of the
:eventsmodule:exhibitionsmoduleand
:toursmodule.It also switches the layout used in the three affected fragment classes to be the same file. Future commits can easily build upon a stable basis, but I'd like to receive confirmation that this is indeed the correct direction to bring the project. For that reason, I'd like to receive at least one indicator of approval from each of @caguilar187 , @agrosner , and @sam33rdhakal before merging this in.