-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2017 bae synergistic ANS presentation #4
2017 bae synergistic ANS presentation #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting a draft to me so promptly. However -- this does not build. I had to make numerous edits to get it to build. Please check these simple things (like the response to "make") before requesting a review. I'm afraid this review is a bit fussy. There were spelling issues, there are too many slides, and generally the slides are not interesting or visual enough. Many things in this presentation could be presented as maps rather than tables, for example -- consider whether any, many, or even all of the tables could be made more visually interesting.
acros.aux
Outdated
@@ -0,0 +1,28 @@ | |||
\relax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid committing aux files which are "generated" rather than "source". To avoid accidentally committing files, avoid use of git add *
. Add files intentionally, rather than universally.
acros.tex
Outdated
@@ -1,17 +1,21 @@ | |||
%\newacronym{<++>}{<++>}{<++>} | |||
\newacronym[longplural={metric tons of heavy metal}]{MTHM}{MTHM}{metric ton of heavy metal} | |||
\newacronym{MTHM}{MTHM}{metric ton of heavy metal} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why get rid of longplural?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was an attempt to fix building issues.. but apparently it isn't.. I'll get it back up!
acros.tex
Outdated
\newacronym{AHTR}{AHTR}{Advanced High Temperature Reactor} | ||
\newacronym{ANDRA}{ANDRA}{Agence Nationale pour la gestion des D\'echets RAdioactifs, the French National Agency for Radioactive Waste Management} | ||
\newacronym{ANL}{ANL}{Argonne National Laboratory} | ||
\newacronym{ANL}{ANL}{Argonne Natio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an error that surely won't build.
acros.tex
Outdated
\newacronym{AHTR}{AHTR}{Advanced High Temperature Reactor} | ||
\newacronym{ANDRA}{ANDRA}{Agence Nationale pour la gestion des D\'echets RAdioactifs, the French National Agency for Radioactive Waste Management} | ||
\newacronym{ANL}{ANL}{Argonne National Laboratory} | ||
\newacronym{ANL}{ANL}{Argonne Natio | ||
\newacronym{MTHM}{MTHM}{metric ton of heavy metal}nal Laboratory} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation of error.... also. MTHM already exists above. Consider sorting the file with your text editor. In vim, it's <ESC>:sort
acros.tex
Outdated
@@ -35,16 +39,20 @@ | |||
\newacronym{DSNF}{DSNF}{DOE spent nuclear fuel} | |||
\newacronym{DYMOND}{DYMOND}{Dynamic Model of Nuclear Development } | |||
\newacronym{EBS}{EBS}{Engineered Barrier System} | |||
\newacronym{EDF}{EDF}{Électricité de France} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These unicode characters should not be copy pasted as unicode. Instead, use the latex notation for grave and accent marks. In this case, for the grave:
\newacronym{EDF}{EDF}{\
{E}lectricit`{e} de France}`
future.tex
Outdated
|
||
\begin{frame} | ||
\frametitle{Future Nuclear Projections} | ||
From the World Nuclear Association \cite{world_nuclear_association_nuclear_2017}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State why you're replicating this table. This slide describes the deployment scheme for the reactors in the simulation and is based in reality. It's input to the simulation.
future.tex
Outdated
|
||
|
||
\begin{frame} | ||
\frametitle{Nuclear Projection by Nation} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Simulated European Deployment" perhaps
results.tex
Outdated
@@ -0,0 +1,139 @@ | |||
\subsection{EU Nuclear Operation ~2050} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in about 2050 or until 2050?
results.tex
Outdated
% \scalebox{0.86}{ | ||
\begin{tabular}{|c|c|c|c|} | ||
\hline | ||
Category & Unit & Value & Specifics\\ \hline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
units should probably come after the value.
results.tex
Outdated
\end{frame} | ||
|
||
\begin{frame} | ||
\frametitle{ Tails and UNF Inventory} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No space before T
62432cc
to
5270dba
Compare
4ffdcd4
to
aa4ad46
Compare
Please let me know when this is ready for a re-review. You can do so by @-mentioning me or (I think) by clicking my name in the upper-right reviewers section until the x turns yellow. |
@katyhuff I was gonna wait until the weekend was over, but if you have time now I think it is ready for a re-review. |
@jbae11 -- ok, I went to build it and am still getting the error caused by including the acros file twice. |
7444e3f
to
8d988c0
Compare
I think this looks great! |
Presentation for ANS 2017 Winter conference.