Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of loss module #655

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

thibaultdvx
Copy link
Collaborator

@thibaultdvx thibaultdvx commented Sep 19, 2024

This PR is a review of the loss function module created in #640.

More precisely, I created one config class for each supported loss function, whereas before there was a single config class for all the losses. This enables to create a create_loss_config function that is similar to create_network_config (see #647) and create_metric_config (see #654), and therefore have a consistent behavior across all modules.

I also put all the Enum class in a specific file.

@thibaultdvx thibaultdvx added the refactoring ClinicaDL refactoring 2024 label Sep 19, 2024
@thibaultdvx thibaultdvx mentioned this pull request Sep 20, 2024
Copy link
Collaborator

@camillebrianceau camillebrianceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@thibaultdvx thibaultdvx changed the base branch from refactoring to dev September 23, 2024 16:39
@thibaultdvx thibaultdvx changed the base branch from dev to refactoring September 23, 2024 16:39
@thibaultdvx thibaultdvx merged commit 0f20f7b into aramis-lab:refactoring Sep 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ClinicaDL refactoring 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants