Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a review of the optim module created in #643 .
More precisely, I created one config class for each supported optimizer and LR scheduler, whereas before there was a single config class for all the optimizers and one for all the schedulers. This enables to create
create_optimizer_config
andcreate_lr_scheduler_config
functions that are similar tocreate_network_config
(see #647),create_metric_config
(see #654) andcreate_loss_config
(see #655) and therefore have a consistent behavior across all modules.I also put all the
Enum
class in specific files.