Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review optim module #656

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

thibaultdvx
Copy link
Collaborator

This PR is a review of the optim module created in #643 .

More precisely, I created one config class for each supported optimizer and LR scheduler, whereas before there was a single config class for all the optimizers and one for all the schedulers. This enables to create create_optimizer_config and create_lr_scheduler_config functions that are similar to create_network_config (see #647), create_metric_config (see #654) and create_loss_config (see #655) and therefore have a consistent behavior across all modules.

I also put all the Enum class in specific files.

Copy link
Collaborator

@camillebrianceau camillebrianceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@thibaultdvx thibaultdvx merged commit 048ca39 into aramis-lab:refactoring Sep 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants