Feat/token voting target improvements

packages/contracts/deploy/20_new_version/23_publish.ts

@@ -142,8 +142,12 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
           createVersion: {
             _release: VERSION.release,
             _pluginSetup: setup.address,
-            _buildMetadata: toHex(buildMetadataURI),
-            _releaseMetadata: toHex(releaseMetadataURI),
+            _buildMetadata: ethers.utils.hexlify(
+              ethers.utils.toUtf8Bytes(buildMetadataURI)
+            ),
+            _releaseMetadata: ethers.utils.hexlify(
+              ethers.utils.toUtf8Bytes(releaseMetadataURI)
+            ),
           },
         },
       ],

packages/contracts/hardhat.config.ts

@@ -156,7 +156,7 @@ const config: HardhatUserConfig = {
     deploy: './deploy',
   },
   mocha: {
-    timeout: 60_000,
+    timeout: 6000000,
   },
   solidity: {
     version: '0.8.17',

packages/contracts/src/IMajorityVoting.sol

@@ -36,6 +36,10 @@ interface IMajorityVoting {
     /// @return The support threshold parameter.
     function supportThreshold() external view returns (uint32);
 
+    /// @notice Returns the min approval value stored configured.
+    /// @return The minimal approval value.
+    function minApproval() external view returns (uint256);
+
     /// @notice Returns the minimum participation parameter stored in the voting settings.
     /// @return The minimum participation parameter.
     function minParticipation() external view returns (uint32);
@@ -61,6 +65,13 @@ interface IMajorityVoting {
     /// @return Returns `true` if the participation is greater than the minimum participation and `false` otherwise.
     function isMinParticipationReached(uint256 _proposalId) external view returns (bool);
 
+    /// @notice Checks if the min approval value defined as:
+    ///$$\texttt{minApproval} = \frac{N_\text{yes}}{N_\text{total}}$$
+    /// for a proposal vote is greater or equal than the minimum approval value.
+    /// @param _proposalId The ID of the proposal.
+    /// @return Returns `true` if the participation is greater than the minimum participation and `false` otherwise.
+    function isMinApprovalReached(uint256 _proposalId) external view returns (bool);
+
     /// @notice Checks if an account can participate on a proposal vote. This can be because the vote
     /// - has not started,
     /// - has ended,