Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/token voting target improvements #38

Merged
merged 98 commits into from
Nov 5, 2024
Merged

Feat/token voting target improvements #38

merged 98 commits into from
Nov 5, 2024

Conversation

novaknole
Copy link

@novaknole novaknole commented Oct 20, 2024 •
edited by Rekard0
Loading

Reference: #30

clauBv23 added 30 commits August 26, 2024 13:43
@clauBv23
feat: update majority voting to support min approvals
c4605ea
@clauBv23
ci: separate the updateMinApproval in a different function and add it…
5d955d8 
… to the majority vote base init function
@clauBv23
feat: add minApproval to token voting, duplicate init function to con…
6a2456c 
…tinue supporting old version
@clauBv23
fix: tests and compilation errors
bdba026
@clauBv23
feat: update the token voting setup so the min advance value in prope…
88f9d04 
…rly set when updating or installing
@clauBv23
fix: typo in the setup function selector
635b96c
@clauBv23
feat: add new installation and update param in the build metadata file
42ef256
@clauBv23
fix: update tests to work with new setup and configuration param
77f3d6f
@clauBv23
feat: add natspec comments to the majority votes interface
0403d51
@clauBv23
feat: add natspect comment to the token voting contract
902eb13
@clauBv23
ci: remove not needed contract
7ec12c9
@clauBv23
feat: add natspect and needed event when updating the min approval value
59165e4
@clauBv23
feat: add test for checking the proposal can not be executed when the…
5d1c070 
… min approval is not reached
@clauBv23
feat: define new interfaces to check them on the tests
b6e9ca7
@clauBv23
ci: move the min approval variable definition position
9b7394c
@clauBv23
fix: min approval values
04ca7fb
@clauBv23
feat: add test for edge cases
8955f48
@clauBv23
feat: modify the majority votes init function to receive the min appr…
638ea07 
…oval
@clauBv23
feat: add tets for checking the updateMinApproval function
7ec2e54
@clauBv23
ci: remove comment
e39d535
@clauBv23
feat: add test for old interfaces on majority votes
cb01be0
@clauBv23
fix: import missing constant
f175112
@clauBv23
feat: add validation for minimal approval value
a959426
@clauBv23
fixL typos
c0bd627
@clauBv23
feat: change test to the new initialize function
08409b5
@clauBv23
feat: define the initialize function signature as constant to reuse it
9bc036a
@clauBv23
feat: revert on old initialize function
bb689ff
@clauBv23
feat: use new constant signatures and add test to check deprecated in…
119e15c 
…tialize function reverts
@clauBv23
ci: improve natspec comment
7bf608b
@clauBv23
ci: remove comments
5c04b20
novaknole and others added 28 commits September 28, 2024 12:11
@novaknole
Merge pull request #35 from aragon/feature/add-initializeFrom-upgrade…
4780717 
…-tests

better upgrade tests
@novaknole
callinitialization from osx-commons
2690267
@novaknole
Merge branch 'feat/token-voting-target-improvements' of https://githu…
630bfd9 
…b.com/aragon/token-voting-plugin into feat/token-voting-target-improvements
@novaknole
fix tohex
0647d5d
@novaknole
metadata extension
4f86c7c
@novaknole @brickpop
Update packages/contracts/src/MajorityVotingBase.sol
f316675 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole @brickpop
Update packages/contracts/src/TokenVoting.sol
ccfa5d9 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole @brickpop
Update packages/contracts/src/TokenVoting.sol
d49093c 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole @brickpop
Update packages/contracts/src/TokenVoting.sol
ab1af36 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole @brickpop
Update packages/contracts/src/TokenVotingSetup.sol
3176cd4 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole @brickpop
Update packages/contracts/src/TokenVotingSetup.sol
3de9e37 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole @brickpop
Update packages/contracts/src/TokenVotingSetup.sol
9799f4e 
Co-authored-by: Jør∂¡ <[email protected]>
@novaknole
permission added
7b3d080
@novaknole
Merge pull request #36 from aragon/feature/metadata
ba6dcf8 
metadata extension
@novaknole
metadata rename
4e5d291
@novaknole
fix tests and contract (#37)
a857d9e 
* fix tests and contract

* change

* add actions in proposal id generation

* rename'
@novaknole
condition reorder
8e9b423
@Rekard0
feat: add auth to execute() and update Setup & testing
f365fb5
@Rekard0
add explicit test when auth revert without permission
9f4dbf2
@Rekard0
fix: fix comment
b1969cc
@novaknole
unused comments
1f0faed
@Rekard0
add test for recording vote with tryEralyExecution when call don't ha…
75949c6 
…ve permission
@novaknole
remove .only
a5e7dca
@novaknole
Merge pull request #39 from aragon/feature/add-auth-to-execute
427a7f5 
feat: add auth to execute() and update Setup & testing
@novaknole
hassucceeded
e906746
@novaknole
reverts
def23ed
@novaknole
Merge pull request #40 from aragon/feature/hasSucceeded
d86f894 
hassucceeded
@novaknole
remove comment
2a39ba9
@novaknole novaknole merged commit c7ee602 into develop Nov 5, 2024
2 of 7 checks passed
@novaknole novaknole deleted the feat/token-voting-target-improvements branch November 5, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@novaknole @clauBv23 @Rekard0