-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PE-7090): return records as sorted entries #35
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9a1fc1d
fix(records): return records as sorted entries
atticusofsparta 30824b5
fix(records): do not encode in getter, allow handler to handle encodi…
atticusofsparta e1f8b75
fix(records): return flat map of records with name keys
atticusofsparta ff0a534
fix(readme): update readme
atticusofsparta f0d6e01
fix(readme): update existing handler explanations
atticusofsparta 5a080c7
fix(tests): update unit tests
atticusofsparta 25dc11a
fix(utils): remove unused util
atticusofsparta 16220a9
fix(test): set the state of the target test records manually
atticusofsparta bae6207
Merge branch 'PE-7013-remove-record-fixes' into PE-7090
atticusofsparta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,13 @@ | ||
print("Loading .busted configuration...") | ||
|
||
return { | ||
_all = { | ||
default = { | ||
root = "src", | ||
pattern = "**/*_spec.lua$", | ||
helper = "spec/setup.lua", | ||
verbose = true, | ||
coverage = true, | ||
output = "utfTerminal", | ||
jobs = 4, | ||
}, | ||
default = { | ||
ROOT = {"ant"}, | ||
pattern = "**/*_spec.lua$", | ||
helper = "spec/setup.lua", | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
statsfile = 'coverage/luacov.stats.out'; | ||
reportfile = 'coverage/luacov.report.out'; | ||
deleteStatsFile = false; | ||
include = { "src/" } | ||
exclude = { "crypto", "json", "base64", "ao" } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - generally when testing you should avoid "using the tools your testing" - instead, set the records manually in global state using
_G.Records = {}
and then validate the behaviorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point - 16220a9