fix(PE-7090): return records as sorted entries #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtfiedler
reviewed
Nov 11, 2024
dtfiedler
reviewed
Nov 11, 2024
…ng of the response
dtfiedler
reviewed
Nov 12, 2024
atticusofsparta
force-pushed
the
PE-7090
branch
from
1a49d45 to
f0d6e01
Compare
dtfiedler
reviewed
Nov 12, 2024
dtfiedler
reviewed
Nov 12, 2024
spec/ant_spec.lua
Outdated
Comment on lines
86
to
87
| records.setRecord("zed", string.rep("1", 43), 3600) | ||
| records.setRecord("@", string.rep("1", 43), 3600) |
There was a problem hiding this comment.
nit - generally when testing you should avoid "using the tools your testing" - instead, set the records manually in global state using _G.Records = {} and then validate the behavior
There was a problem hiding this comment.
good point - 16220a9
|
i'd like to see the changes prepped to support this in the ar-io-sdk. bc we have previously returned maps, we'll want to make |
dtfiedler
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.