feat(PE-6228): ant module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 17, 2024 12:55
dtfiedler
reviewed
Jun 17, 2024
dtfiedler
reviewed
Jun 17, 2024
dtfiedler
reviewed
Jun 17, 2024
dtfiedler
reviewed
Jun 17, 2024
package.json
Outdated
Comment on lines
3
to
11
| "build:module": "cd src && ao build && cd .. && yarn load:module", | ||
| "publish:module": "cd src && ao publish process.wasm -w ../tools/key.json --tag=\"Memory-Limit\" --value=\"1-gb\" --tag=\"Compute-Limit\" --value=\"9000000000000\" && cd ..", | ||
| "load:module": "node tools/load-module.js", | ||
| "spawn:module": "node tools/spawn-module.js", | ||
| "build:aos-ant": "node tools/bundle-aos-ant.js", | ||
| "publish:aos-ant": "node tools/bundle-aos-ant.js && node tools/publish-aos-ant.js", | ||
| "load:aos-ant": "node tools/bundle-aos-ant.js && node tools/load-aos-ant.js", | ||
| "spawn:aos-ant": "node tools/spawn-aos-ant.js", | ||
| "test": "node --test --test-concurrency 1 **/*.test.js" |
There was a problem hiding this comment.
i would flip these to be (scope:action) vs. (action:scope)
aos:load,
aos:build,
aos:spawn,
module:build,
module:publish
...
|
please update the README with the specs for the handlers and their required (and optional) inputs |
dtfiedler
reviewed
Jun 18, 2024
package.json
Outdated
Comment on lines
7
to
10
| "aos-ant:build": "node tools/bundle-aos-ant.js", | ||
| "aos-ant:publish": "node tools/bundle-aos-ant.js && node tools/publish-aos-ant.js", | ||
| "aos-ant:load": "node tools/bundle-aos-ant.js && node tools/load-aos-ant.js", | ||
| "aos-ant:spawn": "node tools/spawn-aos-ant.js", |
There was a problem hiding this comment.
Suggested change
| "aos-ant:build": "node tools/bundle-aos-ant.js", | |
| "aos-ant:publish": "node tools/bundle-aos-ant.js && node tools/publish-aos-ant.js", | |
| "aos-ant:load": "node tools/bundle-aos-ant.js && node tools/load-aos-ant.js", | |
| "aos-ant:spawn": "node tools/spawn-aos-ant.js", | |
| "aos:build": "node tools/bundle-aos-ant.js", | |
| "aos:publish": "node tools/bundle-aos-ant.js && node tools/publish-aos-ant.js", | |
| "aos:load": "node tools/bundle-aos-ant.js && node tools/load-aos-ant.js", | |
| "aos:spawn": "node tools/spawn-aos-ant.js", |
dtfiedler
approved these changes
Jun 18, 2024
atticusofsparta
force-pushed
the
PE-6228-ant-module
branch
from
11103c6 to
972b1a7
Compare
… with empty controller array
atticusofsparta
force-pushed
the
PE-6228-ant-module
branch
from
972b1a7 to
66dbb98
Compare
dtfiedler
reviewed
Jun 19, 2024
src/common/records.lua
Outdated
| ttlSeconds = ttlSeconds, | ||
| } | ||
|
|
||
| return "Record set" |
There was a problem hiding this comment.
have this return the actual record details
dtfiedler
reviewed
Jun 19, 2024
src/common/records.lua
Outdated
| assert(nameValidity ~= false, nameValidityError) | ||
| Records[name] = nil | ||
|
|
||
| return "Record removed" |
There was a problem hiding this comment.
don't return this string - return void
atticusofsparta
force-pushed
the
PE-6228-ant-module
branch
from
78cb39c to
1e59f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.