fix(controllers): fix has permission to validate setting a controller…

… with empty controller array

src/common/utils.lua

@@ -221,14 +221,13 @@ function utils.validateOwner(caller)
 end
 
 function utils.assertHasPermission(from)
-	local isController = false
 	for _, c in ipairs(Controllers) do
 		if c == from then
-			isController = true
-			break
+			-- if is controller, return true
+			return
 		end
 	end
-	local hasPermission = isController == true or Balances[from] or Owner == from or ao.env.Process.Id == from
+	local hasPermission = Balances[from] == 1 or Owner == from or ao.env.Process.Id == from
 	assert(hasPermission == true, "Only controllers and owners can set controllers and records.")
 end
 

test/controllers.test.js

@@ -53,5 +53,16 @@ describe('AOS-ANT Controllers', async () => {
     });
 
     assert(result.Messages[0].Data === 'Controller removed');
+
+    const addControllerResult = await handle(
+      {
+        Tags: [
+          { name: 'Action', value: 'Set-Controller' },
+          { name: 'Controller', value: STUB_ADDRESS },
+        ],
+      },
+      result.Memory,
+    );
+    assert.equal(addControllerResult.Messages[0].Data, 'Controller added');
   });
 });

tools/spawn-aos-ant.js

@@ -88,16 +88,21 @@ async function main() {
     const tags = args
       ? Object.entries(args).map(([key, value]) => ({ name: key, value }))
       : [];
-    const result = await ao.dryrun({
-      process: processId,
-      tags: [...tags, { name: 'Action', value: method }],
-      data,
-      signer,
-      Owner: address,
-      From: address,
-    });
+    const result = await ao
+      .message({
+        process: processId,
+        tags: [...tags, { name: 'Action', value: method }],
+        data,
+        signer,
+        Owner: address,
+        From: address,
+      })
+      .catch((e) => e);
 
-    console.dir({ method, result }, { depth: null });
+    console.dir(
+      { method, result: result.message, type: typeof result },
+      { depth: null },
+    );
   }
 }