-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the Probe interface to support optional path, port and scheme properties #566
Open
kabicin
wants to merge
31
commits into
main
Choose a base branch
from
probe-defaults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabicin
force-pushed
the
probe-defaults
branch
from
December 6, 2023 21:54
b7a098e
to
30c28af
Compare
…e-component-operator into probe-defaults
and fix manageTLS to true by default when setting scheme to HTTPS
…e-component-operator into probe-defaults
kabicin
changed the title
Create BaseComponentProbes interface
Extend the Probe interface to support optional port and scheme properties
May 15, 2024
kabicin
changed the title
Extend the Probe interface to support optional port and scheme properties
Extend the Probe interface to support optional path, port and scheme properties
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseComponentProbes
interface so extending operators can override default settings for probes.BaseComponentProbe
wrapper tocorev1.Probe
OptionalHTTPGetActions
wrapper toHTTPGetActions
to setpath
,port
andscheme
as optional.Related issue OpenLiberty/open-liberty-operator#442