Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe configuration should better default port and protocol #442

Open
NottyCode opened this issue Jun 21, 2023 · 1 comment
Open

Probe configuration should better default port and protocol #442

NottyCode opened this issue Jun 21, 2023 · 1 comment
Assignees

Comments

@NottyCode
Copy link
Member

Feature Request

Is your feature request related to a problem?

I can configure the probes to use all default values using {}, but if I want to override some data I suddenly have to configure all the required values. The required values for httpGet are:

  • url path
  • port
  • scheme

I would like to not have to specify this.

Describe the solution you'd like

The port and scheme should be defaulted based on the configuration of other components in the CRD. For example if manageTLS is set to true (I think the default) the port should default to 9443 because that is what we default the service port to. If the service port is configured to a non-default I shouldn't have to reset the port everywhere. Similarly if manageTLS is on scheme should default to https. This is particularly a pain if you configure all the probes because port and scheme have to be set to the same thing for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants