Add handling for unhandled exceptions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
changed the title
tofu-rocketry
force-pushed
the
62-unhandled-exceptions
branch
from
8308add
to
46cd7a5
Compare
Catch IOError in addition to OSError in on_message as there is no real difference between them and we sometimes get the former being raised.
Add try...except to catch ValueErrors raised when there's no blank line beween header and body of an otherwise valid signed message. Raising a CryptoException means that the message will be rejected nicely in Ssm2.on_message.
tofu-rocketry
force-pushed
the
62-unhandled-exceptions
branch
from
46cd7a5
to
ae2ca4d
Compare
gregcorbett
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #62. (Will write up remaining issue separately.)
try...exceptto catchValueErrors raised when there's no blank linebeween header and body of an otherwise valid signed message. Raising a
CryptoExceptionmeans that the message will be rejected nicely inSsm2.on_message.IOErrorin addition toOSErrorinon_messageas there is no realdifference between them and we sometimes get the former being raised.
Part 1 allows the message to be written out to the reject queue. 2 doesn't, but it's an odd situation that will need some more work - see #64.