Catch IOError in addition to OSError in AMS pull #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrha
previously approved these changes
Aug 5, 2019
|
Having seen this in operation, we need to sort out how we acknowledge messages we pull from AMS otherwise we end up in a loop of continually trying to pull down the same message. |
tofu-rocketry
force-pushed
the
unhandled-ams-exception
branch
from
c4b4dae
to
dea7e72
Compare
tofu-rocketry
force-pushed
the
unhandled-ams-exception
branch
from
dea7e72
to
32771e6
Compare
- Catch IOError in addition to OSError in on_message as there is no real difference between them and we sometimes get the former being raised. - Rename 'error' to 'e' to match on_message convention to simplify refactoring later.
tofu-rocketry
force-pushed
the
unhandled-ams-exception
branch
from
32771e6
to
c88d0d9
Compare
|
Closing and noting issue in Issue #116. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was fixed for the original style of messaging in #63 but didn't get carried over for AMS messaging. (There's a large section that should be factored out for both types of messaging to avoid issues like this!)
difference between them and we sometimes get the former being raised.
refactoring later.