Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter options): full size list item targets #31449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(filter options): full size list item targets #31449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions superset-frontend/src/components/DropdownSelectableIcon/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@ const StyleMenuItem = styled(Menu.Item)<{ divider?: boolean }>`
const StyleSubmenuItem = styled.div`
display: flex;
justify-content: space-between;
> span {
width: 100%;
width: 100%;
> div {
flex-grow: 1;
}
`;

Expand All @@ -102,7 +103,7 @@ export default (props: DropDownSelectableProps) => {
() => (label: string | ReactNode, key: string, divider?: boolean) => (
<StyleMenuItem key={key} divider={divider}>
<StyleSubmenuItem>
<span>{label}</span>
{label}
{selectedKeys?.includes(key) && (
<Icons.Check
iconColor={theme.colors.primary.base}
Expand Down
9 changes: 6 additions & 3 deletions ...ontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,13 @@

return (
<>
{/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */}
<span {...getFilterBarTestId('create-filter')} onClick={handleClick}>
<div

Check failure on line 65 in superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx

View workflow job for this annotation

GitHub Actions / frontend-build 

Elements with the 'button' interactive role must be focusable
{...getFilterBarTestId('create-filter')}
onClick={handleClick}
role="button"
>
{children}
</span>
</div>
<FiltersConfigModal
isOpen={isOpen}
onSave={submit}
Expand Down
Loading