Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter options): full size list item targets #31449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rusackas
Copy link
Member

SUMMARY

I found it frustrating you could click the "Add/Edit Links" bar, but it wouldn't work... you had to click the WORDS. Now the layout is fixed so you can click anywhere on the option bar.

Also removed an eslint disablement by adding a role attribute.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Here's a before/after video
https://github.com/user-attachments/assets/025da21f-a570-4aa8-88b4-9e636de6981e

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from geido December 13, 2024 23:14
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants