-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-11349][Sort] Integrate opentelemetry for sort-connectors-v1.15 #11351
Open
qy-liuhuo
wants to merge
7
commits into
apache:master
Choose a base branch
from
qy-liuhuo:INLONG-11349
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+196
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
requested review from
XiaoYou201 and
vernedeng
and removed request for
XiaoYou201
October 13, 2024 13:56
dockerzhang
reviewed
Oct 21, 2024
...ectors/kafka/src/main/java/org/apache/inlong/sort/kafka/source/reader/KafkaSourceReader.java
Outdated
Show resolved
Hide resolved
When integrating sort-connector-kafka-v1.15 and sort-connector-pulsar-v1.15, the unit test fails. I currently think it is a Maven dependency issue, which I will try to resolve later. |
This was referenced Oct 28, 2024
vernedeng
previously approved these changes
Nov 18, 2024
vernedeng
approved these changes
Nov 19, 2024
aloyszhang
approved these changes
Nov 24, 2024
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11349
Motivation
Integrate opentelemetry for sort-connectors-v1.15
Modifications
Integrate opentelemetry for:
However, some connectors that do not conform to the FLIP-27 have not yet been integrated
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation