Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11422][Sort] Redundant&conflicts dependencys of OpenTelemetryLogger #11423

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

qy-liuhuo
Copy link
Contributor

@qy-liuhuo qy-liuhuo commented Oct 28, 2024

Fixes #11422

Motivation

OpenTelemetryLogger adds some opentelemetry-related maven dependency packages to the sort-connector-base module.

However, these packages have some redundancy and conflicts with inlong's original opentelemetry packages.

This results in unit tests failing when integrating some connectors(https://github.com/apache/inlong/pull/11351#issuecomment-2425694927)

Modifications

Remove some opentelemetry dependencys in inlong-sort/sort-flink/base/pom.xml

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@qy-liuhuo qy-liuhuo changed the title [INLONG-11422][Sort] redundant&conflicts dependencys of OpenTelemetry… [INLONG-11422][Sort] redundant&conflicts dependencys of OpenTelemetryLogger Oct 28, 2024
@dockerzhang dockerzhang changed the title [INLONG-11422][Sort] redundant&conflicts dependencys of OpenTelemetryLogger [INLONG-11422][Sort] Redundant&conflicts dependencys of OpenTelemetryLogger Oct 29, 2024
@dockerzhang dockerzhang merged commit 8d110d6 into apache:master Oct 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Sort] redundant&conflicts dependencys of OpenTelemetryLogger
5 participants