Build: Upgrade to Apache RAT 0.16, scanning hidden directories and adding missing ASF header #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding missing ASF header
|
@Fokko can you please take a look ? Thanks ! |
nastra
approved these changes
Jan 17, 2024
| @@ -68,7 +68,7 @@ mkdir -p "$FWDIR"/lib | |||
| } | |||
|
|
|||
| mkdir -p build | |||
| $java_cmd -jar "$rat_jar" -E "$FWDIR"/dev/.rat-excludes -d "$FWDIR" > build/rat-results.txt | |||
| $java_cmd -jar "$rat_jar" --scan-hidden-directories -E "$FWDIR"/dev/.rat-excludes -d "$FWDIR" > build/rat-results.txt | |||
There was a problem hiding this comment.
Awesome contribution on adding --scan-hidden-directories options at the rat plugin side JB 👍
apache/creadur-rat#166
ajantha-bhat
approved these changes
Jan 17, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
…ding missing ASF header (apache#9495)
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
…ding missing ASF header (apache#9495)
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
…ding missing ASF header (apache#9495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
--scan-hidden-directoriesoptionCloses #9494