Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade to RAT 0.16.1, scanning hidden directories and adding missing ASF headers #1396

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

manuzhang
Copy link
Contributor

No description provided.

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's weird that these are missed given that we have the RAT check to run on GitHub Action https://github.com/apache/iceberg-python/blob/main/.github/workflows/license_check.yml

@kevinjqliu
Copy link
Contributor

Ok looks like RAT v0.15 does not scan hidden directories by default. See similar issue apache/datafusion#9851

The Java Iceberg repo has updated the check-license script to use RAT v0.16.1 with the --scan-hidden-directories option (apache/iceberg #9495 and apache/iceberg #9579).

This change should catch the missing ASF headers in the ./github dir

@manuzhang do you mind including this in the current PR?

@manuzhang manuzhang changed the title Add missing license headers Build: Upgrade to RAT 0.16.1, scanning hidden directories and adding missing ASF headers Dec 4, 2024
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally with RAT 0.16.1. All 4 files missing header addressed in this PR.

ERROR: Ignored 0 lines in your exclusion files as comments or empty lines.
Could not find Apache license headers in the following files:
 !????? /Users/kevinliu/repos/iceberg-python/.github/ISSUE_TEMPLATE/iceberg_bug_report.yml
 !????? /Users/kevinliu/repos/iceberg-python/.github/ISSUE_TEMPLATE/iceberg_improvement.yml
 !????? /Users/kevinliu/repos/iceberg-python/.github/ISSUE_TEMPLATE/iceberg_question.yml
 !????? /Users/kevinliu/repos/iceberg-python/.github/workflows/check-md-link.yml
name: Iceberg Bug report ??
      label: Please describe the bug ??

@kevinjqliu kevinjqliu merged commit a6035ba into apache:main Dec 4, 2024
8 checks passed
@kevinjqliu
Copy link
Contributor

thanks for the contribution @manuzhang !

@manuzhang manuzhang deleted the add-license branch December 5, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants