Build: Define strict version for Flink / Jackson / Hive2 / Tez 0.8 #9484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
gradle-strict-version-def
branch
from
94c7f3d to
5ceb69b
Compare
When running into this issue, the build used Flink 1.18.0. I've noticed that we were silently using Flink 1.18.1 because a new patch version was just released, which caused a test to fail. This is because of how `strictly` and `prefer` (or even `require`) version definitions typically work. According https://docs.gradle.org/current/userguide/rich_versions.html Gradle would select a patch version as long as it matches the version range defined in `strictly`, which isn't necessarily what we want for those libraries. I've changed them all to not use version ranges.
nastra
force-pushed
the
gradle-strict-version-def
branch
from
5ceb69b to
78079a6
Compare
|
Yeah I think pinning these specific versions for these dependencies is a good idea. Silently pulling in newer dependencies and trying to debug why some test is failing is never fun. It becomes much easier to debug when we explicitly are changing the version since we know the change that is being made. |
amogh-jahagirdar
approved these changes
Jan 18, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running into this issue, the build used Flink 1.18.0. I've noticed that we were silently using Flink 1.18.1 because a new patch version was just released, which caused a test to fail. This is because of how
strictlyandprefer(or evenrequire) version definitions work.According to https://docs.gradle.org/current/userguide/rich_versions.html Gradle would select a patch version as long as it matches the version range defined in
strictly, which isn't necessarily what we want for those libraries.I've changed them all to not use version ranges.