Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor version for striclty libs versions #9886

Closed
wants to merge 1 commit into from

Conversation

artyrian
Copy link

@artyrian artyrian commented Mar 7, 2024

#9484

and there is also a confilict with jackson 2.15.4 and spark 3.5 on gradle 8.4:

java.lang.IllegalArgumentException: Unsupported class file major version 65

@artyrian artyrian marked this pull request as ready for review March 7, 2024 01:11
@nastra
Copy link
Contributor

nastra commented Mar 7, 2024

@artyrian can you please add some additional context and a reproducible example on how you ran into that issue?

@artyrian
Copy link
Author

During the assembly of release 1.4.3, classes from JDK 21 started to inadvertently mix into the runtime classpath. The build began to fail with the error java.lang.IllegalArgumentException: Unsupported class file major version 65.

This issue arose because there was a minor update to the Jackson215 dependency described in Gradle for release 1.4.3. This dependency change began causing build failures as detailed here: https://github.com/apache/iceberg/blob/1.4.x/gradle/libs.versions.toml#L40.

At the time of the build, Jackson215 was at version 2.15.2, but it has since been updated to 2.15.4. Due to this update, JDK 21 classes began to get mixed into the runtime classpath. The specific change between these versions can be found here: FasterXML/jackson-core@jackson-core-2.15.3...jackson-core-2.15.4#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R219.

A proper fix is already in place in the main branch for a different reason. b6cefe5
However, to fix the build of the release version, it was necessary to apply the following patch and, as a precaution, lock down all minor versions.

This issue reproduces when attempting to build the project using JDK17 and Gradle 8.4.

@artyrian artyrian mentioned this pull request Mar 12, 2024
@nastra
Copy link
Contributor

nastra commented Mar 12, 2024

Just merging this change to the 1.4.x branch won't make this immediately available. The community would have to do an actual 1.4.4 release in such a case. We just released 1.5.0, so as a first step I would suggest to upgrade to the latest version where this issue is fixed.

alexyin1 pushed a commit to alexyin1/iceberg that referenced this pull request Apr 29, 2024
@nastra nastra closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants