Core, Spark, Flink, Hive: Remove unused failsafe dependency from core and add Failsafe to runtime LICENSE(s) #11816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add Failsafe to runtime LICENSE(s)
amogh-jahagirdar
requested review from
bryanck,
rdblue,
nastra and
danielcweeks
Comment on lines
+725
to
+728
| Group: dev.failsafe Name: failsafe Version: 3.3.2 | ||
| Project URL (from POM): https://github.com/failsafe-lib/failsafe | ||
| License (from POM): Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt | ||
|
|
There was a problem hiding this comment.
I just followed the KC format for the license, cc @bryanck
nastra
approved these changes
Dec 19, 2024
Fokko
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes unused failsafe from core (it was an oversight to include it in core as part of c0d73f4#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7 , we ended up isolating the retry behavior just to AWS).
For clarity this change also adds Failsafe to the Runtime LICENSE(s) for the runtime artifacts which depend on iceberg-aws just to fall in line with our practice of including dependencies (although it's not required as per https://infra.apache.org/licensing-howto.html#alv2-dep since Failsafe is Apache 2.0 Licensed).
Note Failsafe has no Notice of its own.