Core, Spark, Flink, Hive: Remove unused failsafe dependency from core and add Failsafe to runtime LICENSE(s) #11828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add Failsafe to runtime LICENSE(s)
danielcweeks
approved these changes
Dec 19, 2024
bryanck
approved these changes
Dec 19, 2024
|
Thanks @danielcweeks @bryanck for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #11816 is something we should cherry pick to 1.7.x. Even though Failsafe is an Apache License 2.0 project with zero-dependencies of it's own, and no NOTICE file, in the Iceberg project historically we've always followed the practice of including the dependencies in Runtime LICENSE(s). Though not strictly required as per https://infra.apache.org/licensing-howto.html#alv2-dep , it's probably best to just keep aspects like LICENSE(s) consistent for future releases. Automation here is the ideal see #11559, that way aspects like this can just work but for the time being we don't really have that at the moment, so taking the 1.7.2 opportunity to at least fix the failsafe case.