FIX: fix padstack def

src/pyedb/configuration/cfg_padstacks.py

@@ -124,6 +124,15 @@ def set_parameters_to_edb(self):
         if self.solder_ball_parameters:
             self._set_solder_parameters_to_edb(self.solder_ball_parameters)
 
+    def retrieve_parameters_from_edb(self):
+        self.name = self._pyedb_obj.name
+        self.hole_plating_thickness = self._pyedb_obj.hole_plating_thickness
+        self.material = self._pyedb_obj.material
+        self.hole_range = self._pyedb_obj.hole_range
+        self.pad_parameters = self._get_pad_parameters_from_edb()
+        self.hole_parameters = self._get_hole_parameters_from_edb()
+        self.solder_ball_parameters = self._get_solder_parameters_from_edb()
+
     def _set_solder_parameters_to_edb(self, parameters):
         pdef_data = self._pyedb_obj._padstack_def_data
 
@@ -158,15 +167,6 @@ def _get_solder_parameters_from_edb(self):
         }
         return parameters
 
-    def retrieve_parameters_from_edb(self):
-        self.name = self._pyedb_obj.name
-        self.hole_plating_thickness = self._pyedb_obj.hole_plating_thickness
-        self.material = self._pyedb_obj.material
-        self.hole_range = self._pyedb_obj.hole_range
-        self.pad_parameters = self._get_pad_parameters_from_edb()
-        self.hole_parameters = self._get_hole_parameters_from_edb()
-        self.solder_ball_parameters = self._get_solder_parameters_from_edb()
-
     def _get_pad_parameters_from_edb(self):
         """Pad parameters.
 

src/pyedb/configuration/configuration.py

@@ -134,13 +134,17 @@ def run(self, **kwargs):
 
         # Configure stackup
         if kwargs.get("fix_padstack_def"):
+            from pyedb.configuration.cfg_padstacks import CfgPadstackDefinition
+
             pedb_defs = self._pedb.padstacks.definitions
-            temp = {}
-            for name, pdef in pedb_defs.items():
-                temp[name] = pdef.get_properties()
+            temp = []
+            for _, pdef in pedb_defs.items():
+                cfg_def = CfgPadstackDefinition(self._pedb, pdef)
+                cfg_def.retrieve_parameters_from_edb()
+                temp.append(cfg_def)
             self.cfg_data.stackup.apply()
-            for name, pdef_p in temp.items():
-                pedb_defs[name].set_properties(**pdef_p)
+            for cfg_pdef in temp:
+                cfg_pdef.set_parameters_to_edb()
         else:
             self.cfg_data.stackup.apply()
 

tests/legacy/system/test_edb_configuration_2p0.py

@@ -626,7 +626,8 @@ def test_09_padstack_definition(self, edb_examples):
 
         data = {"padstacks": {"definitions": [DEFINITION], "instances": [INSTANCE]}}
         edbapp = edb_examples.get_si_verse()
-        assert edbapp.configuration.load(data, apply_file=True)
+        assert edbapp.configuration.load(data, apply_file=False)
+        edbapp.configuration.run()
         data_from_layout = edbapp.configuration.get_data_from_db(padstacks=True)
         pdef = [i for i in data_from_layout["padstacks"]["definitions"] if i["name"] == "v35h15"][0]