Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fix padstack def #964

Merged
merged 3 commits into from
Jan 7, 2025
Merged

FIX: fix padstack def #964

merged 3 commits into from
Jan 7, 2025

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a linked an issue Jan 3, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the testing Anything related to testing label Jan 3, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (f20b61e) to head (25aff8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files         160      160           
  Lines       21098    21120   +22     
=======================================
+ Hits        17442    17462   +20     
- Misses       3656     3658    +2     

@hui-zhou-a hui-zhou-a changed the title Fix: fix padstack def FIX: fix padstack def Jan 3, 2025
@hui-zhou-a hui-zhou-a removed the testing Anything related to testing label Jan 7, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pyedb/configuration/cfg_padstacks.py Show resolved Hide resolved
@hui-zhou-a hui-zhou-a merged commit 0424273 into main Jan 7, 2025
30 checks passed
@hui-zhou-a hui-zhou-a deleted the fix-fix_padstack_def branch January 7, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants