Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: return error message when trying to create_ports_on_pins of RLC comp #407

Closed
wants to merge 3 commits into from
Closed

FIX: return error message when trying to create_ports_on_pins of RLC comp #407

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb0931
FIX: do_pingroup
gkorompi Apr 24, 2024
4cd660c
FIX: ports in rlc error
gkorompi Apr 24, 2024
e9c82c9
Update src/pyedb/dotnet/edb_core/components.py
gkorompi May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pyedb/dotnet/edb_core/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,6 +785,9 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port
reference_pins = [reference_pins]
if isinstance(refdes, str) or isinstance(refdes, EDBComponent):
refdes = self.instances[refdes]
if any(refdes.rlc_values):
self._logger.error("Ports cannot be assigned on RLC components")
return False
if len([pin for pin in pins if isinstance(pin, str)]) == len(pins):
cmp_pins = []
for pin_name in pins:
Expand Down
Loading