FIX: return error message when trying to create_ports_on_pins of RLC comp #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hui-zhou-a
reviewed
Apr 24, 2024
| @@ -785,6 +785,9 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port | |||
| reference_pins = [reference_pins] | |||
| if isinstance(refdes, str) or isinstance(refdes, EDBComponent): | |||
| refdes = self.instances[refdes] | |||
| if refdes.rlc_values: | |||
There was a problem hiding this comment.
It is better to check type rathen than rlc value. Why is RLC not supported?
There was a problem hiding this comment.
Yes but type is EDBComponent for all inputs (even inductors, caps etc). Ports are not successfully created on RLC pins. Should this be added for 3DL?
There was a problem hiding this comment.
@gkorompi there is a command to replace RLC by ports which deactivate component and create a circuit port. You might want to call this one when you hit such component ?
Also also rather component type instead of rlc_value.
SMoraisAnsys
reviewed
May 3, 2024
I am ok with pr, even though this method is wired to me. |
Co-authored-by: Sébastien Morais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.