-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell layer selection #769
Open
janvonrickenbach
wants to merge
28
commits into
master
Choose a base branch
from
jvonrick/add_shell_layer_selection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5be5b17
Fix elemental scoping if force_elemental nodal is true. Also fixes ht…
janvonrickenbach b1a8600
Remove duplicate tests
janvonrickenbach 16908d9
Fix boolean conversion and add elements from nodes selection
janvonrickenbach b4258b7
Remove obsolete tests
janvonrickenbach b5ecf45
Add more tests for different types of selections
janvonrickenbach 52f4d39
Fix code quality issue
janvonrickenbach 4bec279
Update src/ansys/dpf/post/selection.py
janvonrickenbach 91892eb
Add comment
janvonrickenbach 65720c1
Working version with rescoping at the end of the workflow
janvonrickenbach 5fb222d
Make named selections consistent
janvonrickenbach bbfac0b
Add additional test for single node selection
janvonrickenbach 06081da
Merge branch 'refs/heads/master' into jvonrick/fix_selections_with_mu…
janvonrickenbach 03a35ae
Initial working version. Shell layer workflow will be removed and she…
janvonrickenbach 9d9d542
Also test averaged nodes
janvonrickenbach 7019a4b
Remove skip duplicate nodes option
janvonrickenbach 87608f5
Make ref results more configurable
janvonrickenbach 1246410
Fix tests
janvonrickenbach d63ca7d
Merge branch 'refs/heads/jvonrick/fix_selections_with_multiple_bodies…
janvonrickenbach 26b9563
Use enums for shell layers
janvonrickenbach 418bc12
Fix elemental case
janvonrickenbach 1aa2bf0
Make all tests pass. solid results on skin for elemental results curr…
janvonrickenbach e1ce841
Split test into functions
janvonrickenbach 8bd018f
Simplify reference data
janvonrickenbach 624f451
Add shell layer selection for all simulation types
janvonrickenbach aa93850
Skip shell layer selection if not shell layers are requested
janvonrickenbach b8130bd
Merge branch 'refs/heads/master' into jvonrick/add_shell_layer_selection
janvonrickenbach 8564cd8
Fix case where no shell layer is selected
janvonrickenbach 787c3df
Skip manual shell layer extraction for nodal results. Add more tests.
janvonrickenbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelNale Just FYI