Add shell layer selection #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul Profizi <[email protected]>
…ltiple_bodies # Conflicts: # tests/test_simulation.py
…ll layer in source operator should be made configurable.
…' into jvonrick/add_shell_layer_selection
Skip shell layers if the are no input for the result operator
janvonrickenbach
commented
Dec 3, 2024
| @@ -169,40 +177,72 @@ def average_per_body_complex_multi_body(): | |||
|
|
|||
|
|
|||
| @dataclasses.dataclass | |||
There was a problem hiding this comment.
We don't need the results per body for elemental results => For elemental results only the combined reference files are used.
janvonrickenbach
commented
Dec 3, 2024
| # shell layer, the shell layer is not selected and the results are split into solids | ||
| # and shells. Here, we add an additional shell layer selection and merge_shell_solid | ||
| # operator to manually merge the results. If the shell layer was already selected, this | ||
| # should do nothing. |
There was a problem hiding this comment.
@MichaelNale Just FYI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 85.12% 85.17% +0.05%
==========================================
Files 52 52
Lines 5175 5201 +26
==========================================
+ Hits 4405 4430 +25
- Misses 770 771 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shell layer selection to _get_result interface.
Todo: