maint: modifying files to conform with "PTH" ruff rule #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
9cf6bfe to
6401495
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
+ Coverage 88.33% 88.35% +0.01%
==========================================
Files 89 89
Lines 10225 10242 +17
==========================================
+ Hits 9032 9049 +17
Misses 1193 1193 |
17 tasks
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
8fbf4c5 to
9e18458
Compare
|
Now all changes so far are passing the tests. |
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
1360f72 to
f4f38f9
Compare
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
880c247 to
76935b8
Compare
moe-ad
changed the title
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
d150fc9 to
0cb5abb
Compare
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
c0f75e7 to
fcd1845
Compare
jorgepiloto
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks for such a big contribution, @moe-ad. This helps a lot with code quality and makes the project more robust.
|
Thank you too @jorgepiloto . |
jorgepiloto
reviewed
Dec 11, 2024
| plugin_path = examples.download_gltf_plugin() | ||
| folder_root = os.path.join(os.getcwd().rsplit("pydpf-core", 1)[0], "pydpf-core") | ||
| plugin_path = Path(examples.download_gltf_plugin()) | ||
| folder_root = Path(__file__).parent.parent.parent |
There was a problem hiding this comment.
This line is the one making the CI/CD to fail. I think the problem is that, this is converted to a notebook by Sphinx gallery and thus, the variable __file__ is no longer present, @moe-ad
moe-ad
force-pushed
the
maint/ruff-rule-migration
branch
from
7449aff to
f4c136b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is associated with #296. Flake9-use-pathlib ruff rule will be addressed via this PR.