-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Junk: will delete the branch shortly #1956
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
- Coverage 88.13% 87.07% -1.07%
==========================================
Files 83 83
Lines 10007 9997 -10
==========================================
- Hits 8820 8705 -115
- Misses 1187 1292 +105 |
Now let's start adding changes incrementally. |
Looks like files in .ci/ are not the culprits. |
dc08436
to
8bf8781
Compare
So one issue discovered. Tests are being made with py3.9 which doesn't support Path.walk(). Causing one failure at this stage. |
It's probably better to work with py3.9 as I do not yet know the full implications of switching the CI/CD test environments to py3.12. I can see a different test now failing when the switch is made to py3.12 in the last commit. |
e038b4f
to
8bf8781
Compare
Changes to the example files causes no test issues. |
d564398
to
67b5041
Compare
2bd9762
to
cd41c46
Compare
bb9a621
to
e2f0a65
Compare
That works. Let's try another one. |
d8ae4e1
to
0d80827
Compare
0d80827
to
9e18458
Compare
mentioning #1949. |
See title