Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junk: will delete the branch shortly #1956

Closed
wants to merge 9 commits into from

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Dec 5, 2024

See title

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (ce858d8) to head (9e18458).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   88.13%   87.07%   -1.07%     
==========================================
  Files          83       83              
  Lines       10007     9997      -10     
==========================================
- Hits         8820     8705     -115     
- Misses       1187     1292     +105     

@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 5, 2024

Now let's start adding changes incrementally.

@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 5, 2024

Looks like files in .ci/ are not the culprits.

@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from dc08436 to 8bf8781 Compare December 5, 2024 17:11
@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 5, 2024

So one issue discovered. Tests are being made with py3.9 which doesn't support Path.walk(). Causing one failure at this stage.

@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 6, 2024

It's probably better to work with py3.9 as I do not yet know the full implications of switching the CI/CD test environments to py3.12. I can see a different test now failing when the switch is made to py3.12 in the last commit.

@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from e038b4f to 8bf8781 Compare December 6, 2024 08:13
@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 6, 2024

Changes to the example files causes no test issues.

@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from d564398 to 67b5041 Compare December 6, 2024 11:20
@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from 2bd9762 to cd41c46 Compare December 6, 2024 14:41
@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from bb9a621 to e2f0a65 Compare December 6, 2024 15:04
@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 6, 2024

That works. Let's try another one.

@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from d8ae4e1 to 0d80827 Compare December 6, 2024 15:58
@moe-ad moe-ad force-pushed the junk/investigate-changes-causing-test-failure branch from 0d80827 to 9e18458 Compare December 6, 2024 16:15
@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 8, 2024

mentioning #1949.

@moe-ad moe-ad closed this Dec 8, 2024
@moe-ad moe-ad deleted the junk/investigate-changes-causing-test-failure branch December 8, 2024 18:46
@moe-ad moe-ad self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant