Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: using pyvista.DynamicScraper() #163

Merged
merged 29 commits into from
Sep 6, 2023
Merged

doc: using pyvista.DynamicScraper() #163

merged 29 commits into from
Sep 6, 2023

Conversation

clatapie
Copy link
Collaborator

Closes #162.

@clatapie clatapie self-assigned this Aug 18, 2023
@clatapie clatapie linked an issue Aug 18, 2023 that may be closed by this pull request
Dynamic examples #162
Closed
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related dependencies Related with project dependencies labels Aug 18, 2023
@clatapie clatapie mentioned this pull request Aug 18, 2023
Draft
@clatapie
Copy link
Collaborator Author

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link

Okay, I will trigger a review of your PR.

@clatapie
Copy link
Collaborator Author

@ansys-reviewer-bot help

ansys-reviewer-bot[bot]
ansys-reviewer-bot bot reviewed Aug 31, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
ansys-reviewer-bot[bot]
ansys-reviewer-bot bot reviewed Aug 31, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
ansys-reviewer-bot[bot]
ansys-reviewer-bot bot reviewed Aug 31, 2023
View reviewed changes
doc/source/conf.py Outdated Show resolved Hide resolved
ansys-reviewer-bot[bot]
ansys-reviewer-bot bot reviewed Aug 31, 2023
View reviewed changes
doc/source/conf.py Outdated Show resolved Hide resolved
@clatapie
Copy link
Collaborator Author

clatapie commented Sep 6, 2023

@ansys-reviewer-bot stop review

@ansys-reviewer-bot
Copy link

Okay, I will not perform any more reviews on your PR.

clatapie and others added 18 commits September 6, 2023 10:27
@clatapie
Copy link
Collaborator Author

clatapie commented Sep 6, 2023

The DynamicScraper renders correctly:
image

To have access to the rendering, the use of the python -m http.server command is necessary as explained in this comment.

germa89
germa89 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

doc/source/conf.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@clatapie clatapie enabled auto-merge (squash) September 6, 2023 15:58
@clatapie clatapie merged commit e7b18a2 into main Sep 6, 2023
17 checks passed
@clatapie clatapie deleted the doc/dynamic-examples branch September 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansys-reviewer-bot ansys-reviewer-bot[bot] ansys-reviewer-bot[bot] left review comments

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

@clatapie clatapie

Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic examples
2 participants
@clatapie @germa89