-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dynamic plots in documentation #2241
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 86.93% 86.92% -0.02%
==========================================
Files 187 187
Lines 14616 14619 +3
==========================================
+ Hits 12707 12708 +1
- Misses 1909 1911 +2
|
The following warning appears EDIT: This can probably be modified as this example shows more than one dynamic figure |
The pyansys-math PR will be used as an example to implement it within PyMAPDL as there are some issues that are not solved for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions need to be addressed, later please request another review.
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
|
Pinging @AlejandroFernandezLuces for visibility. |
Christos is currently working in improving interactive documentation plotters. Here is his PR in case you want to try it out: pyvista/pyvista#4938 |
Co-authored-by: Tetsuo Koyama <[email protected]>
@clatapie can you write up a summarise of this PR situation? |
Now the first one shouldn't happen, I've had to remove subplots from examples to adapt to the new visualization tool. Let me know if you need any help with this PR 🙂 |
Re-attempting this.... |
Closes #2177.