Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new argument err_responses to edit_config in CliconfBase #635

Merged
merged 4 commits into from
May 22, 2024
Merged

Add new argument err_responses to edit_config in CliconfBase #635

merged 4 commits into from
May 22, 2024

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented May 13, 2024 •
edited
Loading

SUMMARY
  • Introduces a new keyword argument err_responses in edit_config to handle module/network resource specific CLI errors which aren't listed in terminal err regexes. This let's keep the err regex list in terminal plugin to be generic and clean. And let modules account for the possible CLI errors that configuration command related to a specific network resource might generate.
ISSUE TYPE
  • Trivial
COMPONENT NAME

plugins/plugin_utils/cliconf_base.py
plugins/module_utils/network/common/rm_base/resource_module.py

@NilashishC NilashishC requested a review from KB-perByte May 13, 2024 15:39
@NilashishC NilashishC added the bug This issue/PR relates to a bug. label May 13, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ca621e8c51094ce9a8d2d4f856b93756

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 NODE_FAILURE Node request 200-0007199525 failed in 0s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 NODE_FAILURE Node request 200-0007199526 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 NODE_FAILURE Node request 200-0007199527 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 NODE_FAILURE Node request 200-0007199528 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 NODE_FAILURE Node request 200-0007199529 failed in 0s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 NODE_FAILURE Node request 200-0007199530 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 NODE_FAILURE Node request 200-0007199531 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 NODE_FAILURE Node request 200-0007199532 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 NODE_FAILURE Node request 200-0007199533 failed in 0s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 NODE_FAILURE Node request 200-0007199534 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 NODE_FAILURE Node request 200-0007199535 failed in 0s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 NODE_FAILURE Node request 200-0007199536 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0007199537 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0007199538 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0007199539 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0007199540 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0007199541 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0007199542 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0007199543 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0007199544 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0007199545 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0007199546 failed in 0s
✔️ build-ansible-collection SUCCESS in 18m 44s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 NODE_FAILURE Node request 200-0007199547 failed in 0s
❌ ansible-tox-linters FAILURE in 16m 54s
✔️ ansible-galaxy-importer SUCCESS in 4m 46s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7fa0cf7039534bf7bf34bf9a953d058d

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 RETRY_LIMIT in 9m 54s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 29m 48s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 04m 55s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 6m 49s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 14m 14s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 17m 46s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 15m 52s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 6m 34s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 17m 50s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 17m 57s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 15m 57s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 10m 18s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0007204036 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0007204037 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0007204038 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0007204039 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0007204040 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0007204041 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0007204042 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0007204043 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0007204044 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0007204045 failed in 0s
✔️ build-ansible-collection SUCCESS in 12m 14s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 13m 10s
❌ ansible-tox-linters FAILURE in 12m 01s
✔️ ansible-galaxy-importer SUCCESS in 5m 28s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b470685a177b490aa81a8d748f592fc2

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 15m 22s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 RETRY_LIMIT in 4m 29s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 03m 46s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 5m 58s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 15m 23s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 20m 37s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 17m 24s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 5m 46s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 16m 17s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 17m 55s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 15m 28s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 6m 01s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0007207948 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0007207949 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0007207950 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0007207951 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0007207952 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0007207953 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0007207954 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0007207955 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0007207956 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0007207957 failed in 0s
✔️ build-ansible-collection SUCCESS in 12m 32s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 5m 55s
❌ ansible-tox-linters FAILURE in 10m 48s
✔️ ansible-galaxy-importer SUCCESS in 5m 39s

@NilashishC NilashishC changed the title Allow ansible_port with httpapi connection Add new argument err_responses to edit_config in CliconfBase May 17, 2024
@NilashishC NilashishC added skip-changelog A trivial PR not requiring a change log for users and removed bug This issue/PR relates to a bug. labels May 17, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9ec73b695dbe4fd3bdc75ebcc34f989a

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 16m 00s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 38m 34s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 RETRY_LIMIT in 9m 57s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 10m 26s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 16m 16s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 18m 22s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 16m 59s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 9m 27s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 16m 09s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 19m 24s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 16m 10s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 5m 53s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0007208763 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0007208764 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0007208765 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0007208766 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0007208767 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0007208768 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0007208769 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0007208770 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0007208771 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0007208772 failed in 0s
✔️ build-ansible-collection SUCCESS in 12m 10s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 9m 05s
❌ ansible-tox-linters FAILURE in 11m 29s
✔️ ansible-galaxy-importer SUCCESS in 5m 40s

@NilashishC
use kwargs
69c4b2c 
Signed-off-by: NilashishC <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/01f3730bc9d54995a08358600d2d1951

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 19m 27s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 RETRY_LIMIT in 9m 54s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 06m 35s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 11m 11s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 RETRY_LIMIT in 10m 23s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 21m 00s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 17m 35s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 5m 25s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 RETRY_LIMIT in 1m 26s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 18m 52s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 17m 01s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 11m 07s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0007213333 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0007213334 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0007213335 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0007213336 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0007213337 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0007213338 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0007213339 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0007213340 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0007213341 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0007213342 failed in 0s
✔️ build-ansible-collection SUCCESS in 12m 56s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 2m 39s
❌ ansible-tox-linters FAILURE in 12m 13s
✔️ ansible-galaxy-importer SUCCESS in 5m 32s

@NilashishC NilashishC merged commit d579c74 into ansible-collections:main May 22, 2024
55 of 56 checks passed
@NilashishC NilashishC deleted the fix_253 branch May 22, 2024 07:34
@happly happly mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruchip16 Ruchip16 Ruchip16 approved these changes

@rohitthakur2590 rohitthakur2590 rohitthakur2590 approved these changes

@KB-perByte KB-perByte KB-perByte approved these changes

Assignees
No one assigned
Labels
skip-changelog A trivial PR not requiring a change log for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NilashishC @KB-perByte @rohitthakur2590 @Ruchip16 @roverflow